Support per-point experimental IDT criteria - #214
Merged
Merged
Conversation
alongd
force-pushed
the
i111-per-point-idt
branch
from
September 27, 2026 08:04
5b6d5d7 to
bcd9eb4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
==========================================
+ Coverage 81.55% 81.66% +0.10%
==========================================
Files 78 78
Lines 12467 12726 +259
Branches 2645 2684 +39
==========================================
+ Hits 10168 10393 +225
- Misses 1671 1692 +21
- Partials 628 641 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Address the non-finite time validation, unresolved-criterion classification, and v1 example wiring issues.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds versioned, validated per-point experimental IDT criteria while preserving legacy behavior.
Changes:
- Adds schema validation, unit conversion, and typed refusals.
- Simulates shock-tube and RCM points directly with source-defined criteria.
- Adds tests, documentation, and a v1 YAML example.
| File | Summary |
|---|---|
tests/test_simulate/test_experimental_idt.py |
Tests schema validation and end-to-end IDT behavior. |
t3/simulate/cantera_idt.py |
Implements per-point simulation and scoring; unresolved criteria need distinct classification from simulation failures. |
t3/schema.py |
Defines versioned IDT models; non-finite experimental times must be rejected. |
examples/idt_with_experiment/experimental_idt_v1.yaml |
Provides the versioned input example. |
docs/input_reference.md |
Documents the new experimental IDT format. |
docs/examples.md |
Documents usage; the runnable example should exercise the new v1 input. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
alongd
force-pushed
the
i111-per-point-idt
branch
from
September 27, 2026 08:52
bcd9eb4 to
619ef06
Compare
alongd
added a commit
that referenced
this pull request
Sep 28, 2026
Follow-up to #214. Refuse versioned experimental IDT points whose delay, converted to seconds, exceeds 10 s; guard the per-point integration horizon against non-finite values; and range-check temperatures after conversion to Kelvin so valid degC points (0 degC, -20 degC) are accepted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
No Copilot review requested; the repository workflow will handle it after CI.